Fix a compatibility error in CredentialsProvider
#495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer calling deprecated overrides of `getCredentials(..., Item, ...)` if implemented rather than resolving closest `ItemGroup`.
Vlatombe
commented
Nov 8, 2023
| @@ -1255,7 +1255,7 @@ public <C extends Credentials> List<C> getCredentials(@NonNull Class<C> type, | |||
| @NonNull Item item, | |||
| @Nullable org.acegisecurity.Authentication authentication) { | |||
| Objects.requireNonNull(item); | |||
| return getCredentialsInItemGroup(type, item.getParent(), authentication == null ? null : authentication.toSpring(), List.of()); | |||
| return getCredentialsInItemFallback(type, item, authentication == null ? null : authentication.toSpring(), List.of()); | |||
There was a problem hiding this comment.
Prevents infinite recursion in case the overrides delegates to super implementation.
raul-arabaolaza
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #490
Prefer calling deprecated overrides of
getCredentials(..., Item, ...)if implemented rather than resolving closestItemGroup.Testing done
Submitter checklist